-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outlier detection load balancer #9447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temawi
force-pushed
the
outlier-detection
branch
5 times, most recently
from
August 15, 2022 03:32
18bb3f4
to
d275d72
Compare
temawi
force-pushed
the
outlier-detection
branch
from
August 15, 2022 03:53
d275d72
to
ffe1dd4
Compare
murgatroid99
suggested changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ejection algorithms mostly look good, but I found a few issues.
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
temawi
force-pushed
the
outlier-detection
branch
from
August 15, 2022 21:54
66f03d5
to
0191a3b
Compare
larry-safran
requested changes
Aug 16, 2022
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
Aug 16, 2022
ejona86
reviewed
Aug 16, 2022
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
Outdated
Show resolved
Hide resolved
temawi
force-pushed
the
outlier-detection
branch
from
August 16, 2022 23:16
4cc9c8d
to
4531ad3
Compare
temawi
force-pushed
the
outlier-detection
branch
from
August 17, 2022 03:20
4531ad3
to
f8191b3
Compare
murgatroid99
approved these changes
Aug 17, 2022
larry-safran
approved these changes
Aug 17, 2022
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Aug 22, 2022
New outlier detection load balancer. Tracks all RPC results to the addresses it is configured with and periodically attempts to detect outlier. It wraps a child load balancer from which it hides any addresses that are deemed outliers. As specified in gRFC A50: gRPC xDS Outlier Detection Support: https://github.com/grpc/proposal/blob/master/A50-xds-outlier-detection.md
temawi
added a commit
that referenced
this pull request
Aug 22, 2022
New outlier detection load balancer. Tracks all RPC results to the addresses it is configured with and periodically attempts to detect outlier. It wraps a child load balancer from which it hides any addresses that are deemed outliers. As specified in gRFC A50: gRPC xDS Outlier Detection Support: https://github.com/grpc/proposal/blob/master/A50-xds-outlier-detection.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new load balancer that tracks all RPC results to the addresses it is configured with and periodically attempts to detect outlier. It wraps a child load balancer that it hides any addresses that are deemed outliers.
Implementation follows the specification in gRFC A50: gRPC xDS Outlier Detection Support